On 06/02/2025 10:02, Tudor Ambarus wrote: > >>> + np = of_parse_phandle(dev->of_node, "exynos,acpm_ipc", 0); >> You need bindings for this somewhere and fix the underscore->hyphen... >> and vendor prefix. It really would not be accepted that way so please >> post consumer bindings anywhere. > > There's no consumer upstreamed yet, I don't know where I shall specify > it. How about keeping the function name and modify the declaration to > > +static const struct acpm_handle *acpm_get_by_phandle(struct device_node > *np, > + const char *property) > > This shall be in line with the syscon API and doesn't force me to > introduce bindings for the consumers now. > Good for me. Best regards, Krzysztof
