On 06/02/2025 09:08, Ben Zong-You Xie wrote: > On Fri, Jan 24, 2025 at 08:30:48AM +0100, Krzysztof Kozlowski wrote: >> [EXTERNAL MAIL] >> >> On 23/01/2025 20:35, Ben Zong-You Xie wrote: >>> >>> +config PWM_ATCPIT100 >>> + tristate "Andes ATCPIT100 PWM support" >>> + depends on OF && HAS_IOMEM >>> + depends on RISCV || COMPILE_TEST >>> + select REGMAP_MMIO >>> + help >>> + Generic PWM framework driver for ATCPIT100 on Andes AE350 platform >> >> >> Is AE350 a type of a SoC? Looks like. "depends on RISCV" is wrong - >> there is nothing RISC-V specific here. You must depend on given >> SoC/platform. >> > > Hi Krzysztof, > > AE350 is not a SoC. It's just a reference platform to verify Andes CPUs > on FPGA. For further information on AE350, please refer to [1]. Then what is the SoC? > > Also, I will remove "depends on RISCV" and fix the coding style problems No, read the review again and implement it: "You must depend on given SoC/platform." Best regards, Krzysztof
