Re: [PATCH] arm64: tegra: Enable Tegra234 USB remote wakeup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 06, 2025 at 10:27:31PM +0000, Ivy Huang wrote:
> From: Haotien Hsu <haotienh@xxxxxxxxxx>
> 
> Populate the USB wake-up interrupts for Tegra234 to enable
> the USB device to wake the system up from low power modes.
> 
> Signed-off-by: Henry Lin <henryl@xxxxxxxxxx>
> Signed-off-by: Wayne Chang <waynec@xxxxxxxxxx>
> Signed-off-by: Haotien Hsu <haotienh@xxxxxxxxxx>
> Signed-off-by: Ivy Huang <yijuh@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/nvidia/tegra234.dtsi | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index 2601b43b2d8c..bbd5f7c2bf03 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -3254,8 +3254,22 @@
>  			      <0x0 0x03650000 0x0 0x10000>;
>  			reg-names = "hcd", "fpci", "bar2";
>  
> -			interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupts-extended = <&gic GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&gic GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 76 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 77 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 78 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 79 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 80 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 81 IRQ_TYPE_LEVEL_HIGH>,
> +					      <&pmc 82 IRQ_TYPE_LEVEL_HIGH>;
> +			/*
> +			 * wake0, wake1, wake2 are for USB3.0 ports
> +			 * wake3, wake4, wake5, wake6 are for USB2.0 ports
> +			 */
> +			interrupt-names = "xhci", "mbox",
> +				  "wake0", "wake1", "wake2", "wake3",
> +				  "wake4", "wake5", "wake6";

This needs a bindings update because both of these properties aren't
currently allowed. Also, do we need additional handling in the driver to
make the wake events work, or does this work automatically?

At the very least I think we would also need a patch to add the
corresponding wake events to the PMC driver, otherwise these are
probably not going to do anything.

Thierry

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux