Hi Conor, On Thu, 6 Feb 2025 at 23:39, Conor Dooley <conor@xxxxxxxxxx> wrote: > > On Thu, Feb 06, 2025 at 09:23:03PM +0530, Naresh Solanki wrote: > > On Thu, 6 Feb 2025 at 01:43, Conor Dooley <conor@xxxxxxxxxx> wrote: > > > On Wed, Feb 05, 2025 at 03:51:25PM +0530, Naresh Solanki wrote: > > > > On Wed, 5 Feb 2025 at 00:52, Conor Dooley <conor@xxxxxxxxxx> wrote: > > > > > On Tue, Feb 04, 2025 at 11:33:03PM +0530, Naresh Solanki wrote: > > > > > > Move dt binding under hwmon/pmbus & align accordingly. > > > > > > > > > > > > Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx> > > > > > > --- > > > > > > .../hwmon/pmbus/infineon,ir38060.yaml | 61 +++++++++++++++++++ > > > > > > .../bindings/regulator/infineon,ir38060.yaml | 45 -------------- > > > > > > 2 files changed, 61 insertions(+), 45 deletions(-) > > > > > > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml > > > > > > delete mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml > > > > > > new file mode 100644 > > > > > > index 000000000000..e1f683846a54 > > > > > > --- /dev/null > > > > > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml > > > > > > @@ -0,0 +1,61 @@ > > > > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > > > > > +%YAML 1.2 > > > > > > +--- > > > > > > +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,ir38060.yaml# > > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > > + > > > > > > +title: Infineon Buck Regulators with PMBUS interfaces > > > > > > + > > > > > > +maintainers: > > > > > > + - Not Me. > > > > > > > > > > How the hell did this get merged! > > > > > > > > > > > + > > > > > > +properties: > > > > > > + compatible: > > > > > > + enum: > > > > > > + - infineon,ir38060 > > > > > > + - infineon,ir38064 > > > > > > + - infineon,ir38164 > > > > > > + - infineon,ir38263 > > > > > > + > > > > > > + reg: > > > > > > + maxItems: 1 > > > > > > + > > > > > > + regulators: > > > > > > + type: object > > > > > > + description: > > > > > > + list of regulators provided by this controller. > > > > > > > > > > Can you explain why this change is justified? Your commit message is > > > > > explaining what you're doing but not why it's okay to do. > > > > > > > This is based on other similar dt-bindings under hwmon/pmbus. > > > > > > Okay, but what I am looking for is an explanation of why it is okay to > > > change the node from > > > > > > | regulator@34 { > > > | compatible = "infineon,ir38060"; > > > | reg = <0x34>; > > > | > > > | regulator-min-microvolt = <437500>; > > > | regulator-max-microvolt = <1387500>; > > > | }; > > As I have understood the driver, this isn't supported. > > > > > > to > > > > > > | regulator@34 { > > > | compatible = "infineon,ir38060"; > > > | reg = <0x34>; > > > | > > > | regulators { > > > | vout { > > > | regulator-name = "p5v_aux"; > > > | regulator-min-microvolt = <437500>; > > > | regulator-max-microvolt = <1387500>; > > > | }; > > > | }; > > Above is the typical approach in other pmbus dt bindings. > > Even pmbus driver expects this approach. > > > > > > ? > > > > > > Will the driver handle both of these identically? Is backwards > > > compatibility with the old format maintained? Was the original format > > > wrong and does not work? Why is a list of regulators needed when the > > > device only provides one? > > Driver doesn't support both. > > Based on the pmbus driver original format was wrong. > > pmbus driver looks for a regulator node to start with. > > > > Reference: > > https://github.com/torvalds/linux/blob/master/drivers/hwmon/pmbus/pmbus.h#L515 > > Then all of the in-tree users are all just broken? They're in aspeed > bmcs, so I would not be surprised at all if that were the case. > Can you send a new version with a fixes tag and an explanation that what > was there was wrong? Sure. I will add an explanation in the commit message. I'm not sure what you meant by 'fixes tag' Regards, Naresh > > Cheers, > Conor.
