Hi Geert,
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 06 February 2025 09:53
> Subject: Re: [PATCH v2 6/8] arm64: dts: renesas: rzg3e-smarc-som: Enable SDHI{0,2}
>
> Hi Biju,
>
> On Thu, 6 Feb 2025 at 10:47, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > > -----Original Message-----
> > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > Sent: 06 February 2025 09:36
> > > Subject: Re: [PATCH v2 6/8] arm64: dts: renesas: rzg3e-smarc-som:
> > > Enable SDHI{0,2}
> > >
> > > On Fri, 31 Jan 2025 at 12:25, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > > > Enable eMMC on SDHI0 and SD on SDHI2 on RZ/G3E SMARC SoM.
> > > >
> > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> > > > --- a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> > >
> > > > +&vqmmc_sdhi2 {
> > > > + regulator-name = "SD2_PVDD";
> > >
> > > Why override the name?
> >
> > I just used the label used in RZ/G3E SoM Schematics. So that it
> > appears as
> >
> > cat /sys/class/regulator/regulator.4/name
> > SD2_PVDD
>
> I think this makes it harder to notice that it uses the internal regulator.
Agreed. Won't override.
Cheers,
Biju
