On Thu, Jan 30, 2025 at 02:01:13AM +0800, Mahesh Rao wrote:
> Hi Yilun,
> Thanks for reviewing the patch.
>
> On Sun, 26 Jan 2025 16:28:55 +0800, Xu Yilun wrote:
> > > Add of_platform_default_populate() to stratix10-svc driver as the
> > > firmware/svc node was moved out of soc.
> > > This fixes the failed probing of child drivers of svc node.
> > >
> > > Fixes: 23c3ebed382a ("arm64: dts: socfpga: agilex: move firmware out
> > > of soc node")
>
> > > + ret = of_platform_default_populate(dev_of_node(dev), NULL, dev);
> > > + if (ret < 0) {
> >
> > if (ret) is just fine.
>
> ok ,I will make the change.
>
> >
> > > + of_platform_depopulate(dev);
> > > + goto err_unregister_fcs_dev;
> >
> > You wanna destroy everything even if some child drivers work?
>
> Currently, there is no requirement to retain the driver if a child component fails.
> we will handle it if it is needed in the future.
Does the previous "soc" style population did the same way?
Thanks,
Yilun
>
> > And do we need to do depopulation on driver remove?
>
> I think yes , I have missed this. I will add depopulate in the remove callback().
>
> > I'm actually a little confused how to handle populate() fail and depopulate().
>
> I think this was a mistake on my side. I will make the change in next revision.
>
> Best Regards,
> Mahesh Rao
