Hi Krysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: Thursday, 6 February, 2025 12:36 AM > To: Rabara, Niravkumar L <niravkumar.l.rabara@xxxxxxxxx>; Dinh Nguyen > <dinguyen@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski > <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; > nirav.rabara@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2] arm64: dts: socfpga: agilex5: add NAND board file > > >>> + model = "SoCFPGA Agilex5 SoCDK"; > >>> + compatible = "intel,socfpga-agilex5-socdk", > >>> +"intel,socfpga-agilex5"; > >> > >> > >> You cannot use other boards compatibles. Different device, different > >> compatible. > >> > > > > Same Agilex5 development kit board supports a separate NAND daughter > > card. > > Default daughter card with SDMMC on Agilex5 devkit required to > > replaced with this NAND daughter card to use NAND flash with > > Agilex5 devkit. > > > So different boards? > > > > > Maybe I should replace the "NAND board" to "NAND daughter board" > > for the patch title. > > > > Is this reasonable? > > > Yeah, would be better, but I was not commenting about that. Define what is the > hardware here and use proper compatibles. > Got it. I was under the wrong impression that daughter board can use the base board compatibles. I will add the NAND board's compatible to the bindings and use it here in v3. Thanks, Nirav
