Hi Krysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: Wednesday, 5 February, 2025 7:31 PM > To: Rabara, Niravkumar L <niravkumar.l.rabara@xxxxxxxxx>; Dinh Nguyen > <dinguyen@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski > <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; > nirav.rabara@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2] arm64: dts: socfpga: agilex5: add NAND board file > > On 05/02/2025 11:13, niravkumar.l.rabara@xxxxxxxxx wrote: > > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts > > b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts > > new file mode 100644 > > index 000000000000..ccc9be2cd7c6 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts > > @@ -0,0 +1,89 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2025, Altera Corporation */ #include > > +"socfpga_agilex5.dtsi" > > + > > +/ { > > + model = "SoCFPGA Agilex5 SoCDK"; > > + compatible = "intel,socfpga-agilex5-socdk", "intel,socfpga-agilex5"; > > > You cannot use other boards compatibles. Different device, different > compatible. > Same Agilex5 development kit board supports a separate NAND daughter card. Default daughter card with SDMMC on Agilex5 devkit required to replaced with this NAND daughter card to use NAND flash with Agilex5 devkit. Maybe I should replace the "NAND board" to "NAND daughter board" for the patch title. Is this reasonable? Thanks, Nirav