On 1/30/2025 1:16 PM, Krzysztof Kozlowski wrote: > On 30/01/2025 05:35, Raj Kumar Bhagat wrote: >> @@ -2646,6 +2663,136 @@ static int ath12k_qmi_alloc_target_mem_chunk(struct ath12k_base *ab) >> return ret; >> } >> >> +static int ath12k_qmi_assign_target_mem_chunk(struct ath12k_base *ab) >> +{ >> + struct device_node *mem_node; >> + struct resource res, m3_res; >> + u32 bdf_start_addr; >> + int i, idx, ret; >> + >> + for (i = 0, idx = 0; i < ab->qmi.mem_seg_count; i++) { >> + switch (ab->qmi.target_mem[i].type) { >> + case HOST_DDR_REGION_TYPE: >> + mem_node = ath12k_core_get_reserved_mem_by_name(ab, "q6-region"); > > > Why cannot you use existing API for reserved memory - > of_reserved_mem_lookup()? > The of_reserved_mem_lookup() requires reserved memory node to read the memory and return in the structure "struct reserved_mem". The of_reserved_mem_lookup() would be used after we get the reserved memory node using the API - ath12k_core_get_reserved_mem_by_name(ab, "q6-region"); In next version we would use of_reserved_mem_lookup(), Something like below: mem_node = ath12k_core_get_reserved_mem_by_name(ab, "q6-region"); struct reserved_mem res = of_reserved_mem_lookup(mem_node)