On 30/01/2025 17:31, Nicolas Frattaroli wrote:
> Add the RK3588's standalone hardware random number generator node to its
> device tree, and enable it on the one board I've tested it on and can
> verify it produces good output, the Rock 5B.
>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 9 +++++++++
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 4 ++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> index 8cfa30837ce72581d0b513a8274ab0177eb5ae15..1c72922bcbe1afd7c49beac771f8b7c6e5cc6e05 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> @@ -1921,6 +1921,15 @@ sdhci: mmc@fe2e0000 {
> status = "disabled";
> };
>
> + rng: rng@fe378000 {
> + compatible = "rockchip,rk3588-rng";
> + reg = <0x0 0xfe378000 0x0 0x200>;
> + interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&scmi_clk SCMI_HCLK_SECURE_NS>;
> + resets = <&scmi_reset SCMI_SRST_H_TRNG_NS>;
> + status = "disabled";
Why? What resources are missing?
> + };
> +
> i2s0_8ch: i2s@fe470000 {
> compatible = "rockchip,rk3588-i2s-tdm";
> reg = <0x0 0xfe470000 0x0 0x1000>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index d597112f1d5b8ee0b6a4fa17086c8671a5102583..00a915cf266202e26b274cab962f7bf6bcf76fc1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -430,6 +430,10 @@ &pwm1 {
> status = "okay";
> };
>
> +&rng {
> + status = "okay";
I don't see how RNG is board related.
Best regards,
Krzysztof
