Hi, Am Sonntag, 19. Januar 2025, 23:56:58 MEZ schrieb Olivier Benjamin: > This series adds support for the Pine64 PinePhone Pro's rear and front > cameras in Device Tree. > This is based on some of Ondrej Jirman's patches hosted in his tree at > https://codeberg.org/megi/linux, but I have also fully reviewed and > re-written the code from the RK3399 datasheet, the PinePhone Pro > schematic, and the IMX258-0AQH5 software reference manual. > > I have tested these changes on my PinePhone Pro and am able to take > photos from both cameras using libcamera's cam. > > Signed-off-by: Olivier Benjamin <olivier.benjamin@xxxxxxxxxxx> > --- > Olivier Benjamin (2): > arm64: dts: PinePhone Pro: describe I2c Bus 1 and IMX258 world camera > arm64: dts: PinePhone Pro: describe the OV8858 user camera Patch subject should be "arm64: dts: rockchip: describe the OV8858 user camera on PinePhone Pro" patches need an update to accomodate https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5c96e63301978f4657c9082c55a066763c8db7b1 And please name the new regulator nodes similarly (regulator-foo) Thanks a lot Heiko