On 22/01/2025 21:53, Chris Packham wrote:
>>> };
>>> +
>>> + mdio-controller {
>> No, no resources here, no unit address. Look at other nodes - they have
>> the resource, the address. Mixing such nodes is clear indication this is
>> not correct hardware description and you do this only for Linux.
>>
>> Fold child device into parent.
>
> In this particular case all the mdio stuff is actually contained to a
> range starting at offset 0xca00. I dropped it because it was simpler in
> the driver to use the full 16-bit address rather than trying to use
> offsets from the base address that didn't correspond to the datasheet.
> As you've highlighted that's making the dt-binding impose driver
> specifics so would adding back `mdio-controller@ca00` and `reg = <0xca00
> 0x200>;` be OK even if the driver doesn't actually use them?
If this matches the hardware, then yes.
Best regards,
Krzysztof
