On 1/27/25 03:58, J. Neuschäfer via B4 Relay wrote: > From: "J. Neuschäfer" <j.ne@xxxxxxxxxx> > > Convert the Freescale PowerQUICC SATA controller binding from text form > to YAML. The list of compatible strings reflects current usage. > > Signed-off-by: J. Neuschäfer <j.ne@xxxxxxxxxx> > --- > .../devicetree/bindings/ata/fsl,pq-sata.yaml | 59 ++++++++++++++++++++++ > Documentation/devicetree/bindings/ata/fsl-sata.txt | 28 ---------- > 2 files changed, 59 insertions(+), 28 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ata/fsl,pq-sata.yaml b/Documentation/devicetree/bindings/ata/fsl,pq-sata.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..6af31ffbcad5e9cc83118a0bd8eaf45351a2823f > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/fsl,pq-sata.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ata/fsl,pq-sata.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale 8xxx/3.0 Gb/s SATA nodes > + > +maintainers: > + - J. Neuschäfer <j.ne@xxxxxxxxxx> > + > +description: | > + SATA nodes are defined to describe on-chip Serial ATA controllers. > + Each SATA port should have its own node. Very unclear. The SATA nodes define ports or controllers ? Normally, a single controller can have multiple ports, so the distinction is important. > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - fsl,mpc8377-sata > + - fsl,mpc8536-sata > + - fsl,mpc8315-sata > + - fsl,mpc8379-sata > + - const: fsl,pq-sata > + - const: fsl,pq-sata-v2 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + cell-index: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 3, 4] > + description: | > + 1 for controller @ 0x18000 > + 2 for controller @ 0x19000 > + 3 for controller @ 0x1a000 > + 4 for controller @ 0x1b000 Are you sure these are different controllers ? Are they not different ports of the same controller ? Given that the previous text description define this as "controller index", I suspect these are the port offsets and you SATA nodes define ports, and not controllers. > + > +required: > + - compatible > + - interrupts > + - cell-index > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + sata@18000 { > + compatible = "fsl,mpc8379-sata", "fsl,pq-sata"; > + reg = <0x18000 0x1000>; > + cell-index = <1>; > + interrupts = <44 IRQ_TYPE_LEVEL_LOW>; > + interrupt-parent = <&ipic>; > + }; > diff --git a/Documentation/devicetree/bindings/ata/fsl-sata.txt b/Documentation/devicetree/bindings/ata/fsl-sata.txt > deleted file mode 100644 > index fd63bb3becc9363c520a8fd06629fdc52c4d4299..0000000000000000000000000000000000000000 > --- a/Documentation/devicetree/bindings/ata/fsl-sata.txt > +++ /dev/null > @@ -1,28 +0,0 @@ > -* Freescale 8xxx/3.0 Gb/s SATA nodes > - > -SATA nodes are defined to describe on-chip Serial ATA controllers. > -Each SATA port should have its own node. > - > -Required properties: > -- compatible : compatible list, contains 2 entries, first is > - "fsl,CHIP-sata", where CHIP is the processor > - (mpc8315, mpc8379, etc.) and the second is > - "fsl,pq-sata" > -- interrupts : <interrupt mapping for SATA IRQ> > -- cell-index : controller index. > - 1 for controller @ 0x18000 > - 2 for controller @ 0x19000 > - 3 for controller @ 0x1a000 > - 4 for controller @ 0x1b000 > - > -Optional properties: > -- reg : <registers mapping> > - > -Example: > - sata@18000 { > - compatible = "fsl,mpc8379-sata", "fsl,pq-sata"; > - reg = <0x18000 0x1000>; > - cell-index = <1>; > - interrupts = <2c 8>; > - interrupt-parent = < &ipic >; > - }; > -- Damien Le Moal Western Digital Research
