Hello. > > > I think it's actually better to accept the approach in Alexander's > > > patch, because the whole thing applies to other Rockchip SoCs as well, > > > not just to the RK3588(S). > > > > Anyway, I've just tried it after including the changes below, and > > while /sys/kernel/debug/pinctrl/pinctrl-handles shows the expected > > pinctrls under tsadc, the driver still doesn't seem to be triggering a > > PMIC reset. Weird. Any thoughts welcome. > > I found the culprit. "otpout" (or "default" if we follow Alexander's > suggested approach) pinctrl state should refer to the &tsadc_shut_org > config instead of &tsadc_shut - then the PMIC reset works. Great, I'll use this in v2. Thanks!
