Hi, On Thu, Jan 23, 2025 at 7:54 PM Langyan Ye <yelangyan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > Hi Doug, > Your suggestion is very helpful to me, thank you. One note: when responding on mailing lists, please don't "top post". I personally don't care that much, but many others do. See, for instance; https://subspace.kernel.org/etiquette.html#do-not-top-post-when-replying I'm sure if you search the internet you can find lots of other descriptions about top posting, including the usual: A: No. Q: Should I ever top-post? > I confirmed the controller chips of these two panels, and it turned > out that they use the HX83102 IC, so the correct approach is that I > should add these two MIPI panels to the binding file/driver of the > MIPI controller of HX83102. Yes, that sounds correct to me. So you'd move the bindings patch to add your compatible strings to: Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml ...and you'd add the code to: drivers/gpu/drm/panel/panel-himax-hx83102.c ...when you do this, please make sure you're following the conventions of the "panel-himax-hx83102.c" driver file, like using the hx83102_enable_extended_cmds() function when appropriate and using the defines like "HX83102_SETPOWER", "HX83102_SETDISP", etc. > I would like to ask if I need to release a > v5 version or resend a new email if I do this? IMO you'd call it v5. You should probably drop Neil's Reviewed-by tag in this case since it's a major enough change that you'd want him to re-provide a review. You could add a note to the version history like "Dropped Neil's tags since V5 is very different from V4" or something like that. FWIW, for the bindings patch I would personally use the patch description: Add a new compatible for the panels KINGDISPLAY KD110N11-51IE and STARRY 2082109QFH040022-50E. Both panels use the HX83102 IC so add the compatible to the hx83102 bindings file. > Thank you again for taking the time out of your busy schedule to guide me. The best way you can thank me is to teach others that you're working with the lessons you've learned about working with the upstream kernel mailing lists and sending patches. Maybe provide some internal documentation for other new engineers to follow. :-P -Doug
