Hi Krzysztof On Wed, Jan 22, 2025 at 02:48:07PM +0100, Krzysztof Kozlowski wrote: > On 22/01/2025 14:36, Jacopo Mondi wrote: > >>>> + assigned-clocks: true > >>>> + > >>>> + assigned-clock-rates: true > >>> NAK > >>> > >>> Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak > >>> whatever crap past reviewers. > >>> > >>> Drop all new properties and drop my review tag. > >> > >> > >> OK, will drop all new properties and drop your review tag. Thanks > >> > > > > Krzysztof why should new properties added in-between two revisions be > > dropped ? > > You connected two independent issues. Well, it seems Keke did as well: > >> OK, will drop all new properties and drop your review tag. Thanks If new properties get removed, the tag can then stay, right ? > It is not that some new properties should be dropped, because I don't > like new stuff. It's that these two particular properties - added in > this version, but that's coincidence - are not appropriate and should be > dropped because of that reason: not appropriateness. > > > > > I understand the "drop my tag if you make changes" but I don't get why > > the newly added properties should be removed. > > They are neither needed, nor beneficial. Core schema provides them. > Ok, this is the bit I was missing. I thought that having additionalProperties: false in the schema means that properties not explicitly listed are not valid, but schema validation passes without specifying the two properties, so yeah, these should be dropped. > Best regards, > Krzysztof
