Hi Keke, Krzysztof On Fri, Dec 27, 2024 at 03:38:14PM +0800, Keke Li wrote: > Hi Krzysztof > > Thanks for your reply > > On 2024/12/27 15:19, Krzysztof Kozlowski wrote: > > [You don't often get email from krzysztof.kozlowski@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > > > [ EXTERNAL EMAIL ] > > > > On 27/12/2024 08:09, Keke Li via B4 Relay wrote: > > > From: Keke Li <keke.li@xxxxxxxxxxx> > > > > > > c3-mipi-csi2 is used to receive mipi data from image sensor. > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > Signed-off-by: Keke Li <keke.li@xxxxxxxxxxx> > > > --- > > > .../bindings/media/amlogic,c3-mipi-csi2.yaml | 131 +++++++++++++++++++++ > > > MAINTAINERS | 6 + > > > 2 files changed, 137 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml > > > new file mode 100644 > > > index 000000000000..76b68d1e7316 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml > > > @@ -0,0 +1,131 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-csi2.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Amlogic C3 MIPI CSI-2 receiver > > > + > > > +maintainers: > > > + - Keke Li <keke.li@xxxxxxxxxxx> > > > + > > > +description: > > > + MIPI CSI-2 receiver contains CSI-2 RX PHY and host controller. > > > + It receives the MIPI data from the image sensor and sends MIPI data > > > + to MIPI adapter. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - amlogic,c3-mipi-csi2 > > > + > > > + reg: > > > + maxItems: 3 > > > + > > > + reg-names: > > > + items: > > > + - const: aphy > > > + - const: dphy > > > + - const: host > > > + > > > + power-domains: > > > + maxItems: 1 > > > + > > > + clocks: > > > + maxItems: 2 > > > + > > > + clock-names: > > > + items: > > > + - const: vapb > > > + - const: phy0 > > > + > > > + assigned-clocks: true > > > + > > > + assigned-clock-rates: true > > NAK > > > > Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak > > whatever crap past reviewers. > > > > Drop all new properties and drop my review tag. > > > OK, will drop all new properties and drop your review tag. Thanks > Krzysztof why should new properties added in-between two revisions be dropped ? I understand the "drop my tag if you make changes" but I don't get why the newly added properties should be removed. > > > > Best regards, > > Krzysztof >
