Hi Rob/Conor, On 09/01/25 2:26 am, Martin Blumenstingl wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi Dharma, > > On Wed, Jan 8, 2025 at 4:11 AM <Dharma.B@xxxxxxxxxxxxx> wrote: > [...] >> "One issue is 'compatible' is required. Either that would have to be >> dropped as required." >> >> Instead of just dropping it from "required:", I removed the property >> itself and moved it to another binding. >> >> I will send a v2 by removing it from the required, will it be fine? > For me this is fine. > > My understanding is that if we drop the compatible property completely > then any compatible string will be allowed (for example: compatible = > "random,name"). This is because mmc-slot.yaml inherits the properties > from mmc-controller-common.yaml which itself has > "additionalProperties: true". > However, if we allow it but make it optional it means that there's > only two valid states: > - no compatible property (on the Atmel / Microchip SoCs) > - a compatible property with the value "mmc-slot" (as used on Amlogic > Meson and Cavium Thunder SoCs) > - (anything else is considered invalid) > > Rob, Conor: can confirm this or correct me wherever I got something wrong. > I hope that your feedback will help Dharma write a good patch > description for v2. Shall I proceed with v2 by dropping the compatible from the required property list? > > > Best regards, > Martin > -- With Best Regards, Dharma B.
