On 20/12/24 1:41 am, Conor Dooley wrote: > On Thu, Dec 19, 2024 at 09:40:41AM +0530, Dharma Balasubiramani wrote: >> Move the `compatible` property into its specific binding to make the MMC >> slot more generic and modular. > This makes no sense, as presented. What's the real reason for this > change? You want to ref mmc-slot.yaml but the compatible is causing a > driver to probe? We don’t have the configuration for that driver enabled. Wouldn’t including the compatible in the DTS files without the actual driver be redundant? Is it the correct approach to add the compatible just to fix the dt binding errors? related discussion: https://lore.kernel.org/lkml/63473475-f29e-4a65-a0aa-1f1e4112b57d@xxxxxxxxxxxxx/ > Otherwise, if this is just to avoid having to fix up some devicetree > source files, I don't think we should do this. > > Thanks, > Conor. > >> Signed-off-by: Dharma Balasubiramani<dharma.b@xxxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml | 4 ++++ >> Documentation/devicetree/bindings/mmc/mmc-slot.yaml | 7 +------ >> 2 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml >> index 022682a977c6..7600a4988eca 100644 >> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml >> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.yaml >> @@ -54,6 +54,10 @@ patternProperties: >> A node for each slot provided by the MMC controller >> >> properties: >> + compatible: >> + items: >> + - const: mmc-slot >> + >> reg: >> enum: [0, 1, 2] >> >> diff --git a/Documentation/devicetree/bindings/mmc/mmc-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-slot.yaml >> index 1f0667828063..84c4605658e0 100644 >> --- a/Documentation/devicetree/bindings/mmc/mmc-slot.yaml >> +++ b/Documentation/devicetree/bindings/mmc/mmc-slot.yaml >> @@ -20,19 +20,15 @@ properties: >> $nodename: >> pattern:"^slot(@.*)?$" >> >> - compatible: >> - const: mmc-slot >> - >> reg: >> description: >> the slot (or "port") ID >> maxItems: 1 >> >> required: >> - - compatible >> - reg >> >> -unevaluatedProperties: false >> +additionalProperties: true >> >> examples: >> - | >> @@ -40,7 +36,6 @@ examples: >> #address-cells = <1>; >> #size-cells = <0>; >> slot@0 { >> - compatible = "mmc-slot"; >> reg = <0>; >> bus-width = <4>; >> }; >> >> --- >> base-commit: 7fa366f1b6e376c38966faa42da7f0f2e013fdab >> change-id: 20241219-mmc-slot-0574889daea3 >> >> Best regards, >> -- >> Dharma Balasubiramani<dharma.b@xxxxxxxxxxxxx> -- With Best Regards, Dharma B.
