On Sat, Jan 18, 2025 at 4:08 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 15/01/2025 02:26, Peter Geis wrote: > > > > This is my newly reworked phy driver for the rk3328 usb3 phy. It is > > based loosely on my original version, but as of now almost nothing of > > the original driver remains. The main fix here is the discovery of > > BIT(6) in the interrupt enable grf register fixes the usb3 disconnection > > detection (mostly). On occasion an unpopulated usb3 hub will take > > several seconds to disconnect. However this means all of the hack around > > work to reset the usb core manually is no longer required. > > > BTW, RFC for some maintainers means "do not review, work-in-progress". > For some means "review, but low priority" or "review, but for sure I > have bugs here". I usually review and then someone responds: "it is not > for review, it is just RFC", so to avoid my wasted time please always > mention in cover letter why this is RFC. What do you expect here or why > this is not ready for review as normal patch. Thank you, that makes sense. I marked it as RFC as I'm aware it isn't a perfect solution and there's a lot of undefined values. What I was looking for here was: - Review for code quality, so if I'm completely off track I can get to work fixing it. (Thank you so far) - Sanity testing from others struggling with the issues it fixes. - Feedback from USB engineers about the issues remaining. - Hopefully someone with access to the IP can provide insight into the magic registers. > > Best regards, > Krzysztof
