On 15/01/2025 02:26, Peter Geis wrote: > > This is my newly reworked phy driver for the rk3328 usb3 phy. It is > based loosely on my original version, but as of now almost nothing of > the original driver remains. The main fix here is the discovery of > BIT(6) in the interrupt enable grf register fixes the usb3 disconnection > detection (mostly). On occasion an unpopulated usb3 hub will take > several seconds to disconnect. However this means all of the hack around > work to reset the usb core manually is no longer required. > BTW, RFC for some maintainers means "do not review, work-in-progress". For some means "review, but low priority" or "review, but for sure I have bugs here". I usually review and then someone responds: "it is not for review, it is just RFC", so to avoid my wasted time please always mention in cover letter why this is RFC. What do you expect here or why this is not ready for review as normal patch. Best regards, Krzysztof