Hi,
Thanks for your comment.
2025年1月14日(火) 22:44 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
>
> Hi Krzysztof,
>
> On Sat, Jan 11, 2025 at 10:35 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > On 11/01/2025 09:09, Nobuhiro Iwamatsu wrote:
> > > +++ b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts
> > > + stdout-path = "serial0:115200n8";
> > > + };
> > > +
> > > + memory@48000000 {
> > > + device_type = "memory";
> > > + /* first 128MB is reserved for secure area. */
> > > + reg = <0x0 0x48000000 0x1 0xF8000000>;
> > > + };
> > > +
> > > + reg_3p3v: regulator1 {
> >
> > Keep consistent naming. regulator-1 or the name as in bindings:
> > 'regulator-[0-9]v[0-9]'
>
> Please use the latter...
OK, I will use 'regulator-3v3'.
>
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46
> >
> > > + compatible = "regulator-fixed";
> > > +
> > > + regulator-name = "fixed-3.3V";
> > > + regulator-min-microvolt = <3300000>;
> > > + regulator-max-microvolt = <3300000>;
> > > + regulator-boot-on;
> > > + regulator-always-on;
> > > + };
> > > +
> > > + vqmmc_sdhi0: regulator-vccq-sdhi0 {
> >
> > regulator-2? Why different styles of names?
>
> ... i.e. no numbered regulators, as these tend to cause hard-to-debug
> conflicts.
OK, I will keep regulator-vccq-sdhi0 .
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org / kernel.org}
GPG ID: 32247FBB40AD1FA6
