On 11/01/2025 09:09, Nobuhiro Iwamatsu wrote:
> +++ b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts
> @@ -0,0 +1,138 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +/*
> + * Device Tree Source for Yuridenki-Shokai the Kakip board
> + *
> + * Copyright (C) 2024 Nobuhiro Iwamatsu <iwamatsu@xxxxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/pinctrl/renesas,r9a09g057-pinctrl.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include "r9a09g057.dtsi"
> +
> +/ {
> + model = "Yuridenki-Shokai Kakip Board based on r9a09g057h48";
> + compatible = "yuridenki,kakip", "renesas,r9a09g057h48", "renesas,r9a09g057";
> +
> + aliases {
> + serial0 = &scif;
> + mmc0 = &sdhi0;
> + };
> +
> + chosen {
> + bootargs = "ignore_loglevel";
Not really suitable for mainline DTS. This is just debugging, so drop.
Just like earlycon - not suitable for mainline usage.
> + stdout-path = "serial0:115200n8";
> + };
> +
> + memory@48000000 {
> + device_type = "memory";
> + /* first 128MB is reserved for secure area. */
> + reg = <0x0 0x48000000 0x1 0xF8000000>;
> + };
> +
> + reg_3p3v: regulator1 {
Keep consistent naming. regulator-1 or the name as in bindings:
'regulator-[0-9]v[0-9]'
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46
> + compatible = "regulator-fixed";
> +
> + regulator-name = "fixed-3.3V";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + vqmmc_sdhi0: regulator-vccq-sdhi0 {
regulator-2? Why different styles of names?
> + compatible = "regulator-gpio";
> + regulator-name = "SDHI0 VccQ";
> + gpios = <&pinctrl RZV2H_GPIO(A, 0) GPIO_ACTIVE_HIGH>;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios-states = <0>;
> + states = <3300000 0 1800000 1>;
> + };
> +};
> +
> +&qextal_clk {
> + clock-frequency = <24000000>;
> +};
> +
> +&pinctrl {
> + scif_pins: scif {
> + pins = "SCIF_RXD", "SCIF_TXD";
> + };
> +
> + sd0-pwr-en-hog {
> + gpio-hog;
> + gpios = <RZV2H_GPIO(A, 1) GPIO_ACTIVE_HIGH>;
> + output-high;
> + line-name = "sd0_pwr_en";
> + };
> +
> + sdhi0_pins: sd0 {
> + sd0_data {
No underscores in node names. Please follow DTS coding style.
Best regards,
Krzysztof
