> -----Original Message----- > From: linux-iio-owner@xxxxxxxxxxxxxxx [mailto:linux-iio-owner@xxxxxxxxxxxxxxx] On Behalf Of Jonathan Cameron > Sent: 18 April, 2015 21:09 > To: Tirdea, Irina; linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx; Hartmut Knaack; Lars-Peter Clausen; Peter Meerwald; Rob Herring; Pawel Moll; Mark Rutland; Ian > Campbell; Kumar Gala > Subject: Re: [PATCH 3/3] iio: magn: bmc150_magn: Add devicetree binding documentation > > On 17/04/15 11:50, Irina Tirdea wrote: > > Add binding documentation for Bosch BMC150 magnetometer. > > > > Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx> > > --- > > .../bindings/iio/magnetometer/bmc150_magn.txt | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt > > > > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt > b/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt > > new file mode 100644 > > index 0000000..4ed035c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt > > @@ -0,0 +1,20 @@ > > +* Bosch BMC150 magnetometer sensor > > + > > +http://ae-bst.resource.bosch.com/media/products/dokumente/bmc150/BST-BMC150-DS000-04.pdf > > + > > +Required properties: > > + > > + - compatible : should be "bosch,bmc150_magn" > > + - reg : the I2C address of the magnetometer > > + > > +Optional properties: > > + > > + - gpios : should be device tree identifier of the magnetometer DRDY pin > Hmm. Under device tree this should be done as an interrupt. You only > (currently) need the dubious frig with gpios for ACPI I think. Using the gpios declared like this, it will go the same code path as the ACPI. I wasn't sure which to list in the optional properties, so I used gpios because the other magnetometer device tree bindings listed also gpios. It is better to specify the interrupt directly since it will be handled by the core, so I will remove gpios and list interrupts instead. Thanks, Irina > > + > > +Example: > > + > > +bmc150_magn@12 { > > + compatible = "bosch,bmc150_magn"; > > + reg = <0x12>; > > + interrupt-gpio = <&gpio1 0 1>; > > +}; > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html