On Mon, Jan 13, 2025 at 01:52:01PM -0600, Ninad Palsule wrote: > Hello, > > On 1/8/25 16:34, Rob Herring (Arm) wrote: > > On Wed, 08 Jan 2025 10:36:28 -0600, Ninad Palsule wrote: > > > Hello, > > > > > > Please review the patch set. > > > > > > V3: > > > --- > > > - Fixed dt_binding_check warnings in ipmb-dev.yaml > > > - Updated title and description in ipmb-dev.yaml file. > > > - Updated i2c-protocol description in ipmb-dev.yaml file. > > > > > > V2: > > > --- > > > Fixed CHECK_DTBS errors by > > > - Using generic node names > > > - Documenting phy-mode rgmii-rxid in ftgmac100.yaml > > > - Adding binding documentation for IPMB device interface > > > > > > NINAD PALSULE (7): > > > ARM: dts: aspeed: system1: Add IPMB device > > > ARM: dts: aspeed: system1: Add GPIO line name > > > ARM: dts: aspeed: system1: Add RGMII support > > > ARM: dts: aspeed: system1: Reduce sgpio speed > > > ARM: dts: aspeed: system1: Update LED gpio name > > > ARM: dts: aspeed: system1: Remove VRs max8952 > > > ARM: dts: aspeed: system1: Mark GPIO line high/low > > > > > > Ninad Palsule (3): > > > dt-bindings: net: faraday,ftgmac100: Add phys mode > > > bindings: ipmi: Add binding for IPMB device intf > > > ARM: dts: aspeed: system1: Disable gpio pull down > > > > > > .../devicetree/bindings/ipmi/ipmb-dev.yaml | 44 +++++ > > > .../bindings/net/faraday,ftgmac100.yaml | 3 + > > > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 177 ++++++++++++------ > > > 3 files changed, 165 insertions(+), 59 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml > > > > > > -- > > > 2.43.0 > > > > > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in this > > series. > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > > are fixed by another series. Ultimately, it is up to the platform > > maintainer whether these warnings are acceptable or not. No need to reply > > unless the platform maintainer has comments. > > > > If you already ran DT checks and didn't see these error(s), then > > make sure dt-schema is up to date: > > > > pip3 install dtschema --upgrade > > > > > > New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-system1.dtb' for 20250108163640.1374680-1-ninad@xxxxxxxxxxxxx: > > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: gpio@1e780000: 'hog-0', 'hog-1', 'hog-2', 'hog-3' do not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# > > This is a false positive. So ignoring it. No, it is not. You need to define hog nodes in aspeed,ast2400-gpio.yaml. See other GPIO controller bindings that do this. Rob
