On Thu, Jan 09, 2025 at 10:18:28PM +0100, Dario Binacchi wrote: > +maintainers: > + - Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx> > + > +description: | > + The RCC IP is both a reset and a clock controller. > + The reset phandle argument is the bit number within the RCC registers bank, > + starting from RCC base address. > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: st,stm32f42xx-rcc > + - const: st,stm32-rcc > + - items: > + - enum: > + - st,stm32f469-rcc > + - const: st,stm32f42xx-rcc > + - const: st,stm32-rcc > + - items: > + - const: st,stm32f746-rcc Why this isn't just part of enum with first group/list? Different groups/lists are for different fallbacks and I am pretty sure fallback is the same. > + - const: st,stm32-rcc > + - items: > + - enum: > + - st,stm32f769-rcc > + - const: st,stm32f746-rcc > + - const: st,stm32-rcc > + - items: > + - const: st,stm32h743-rcc Same here. Rest looks good, so with combining entries above: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
