On Tue, Apr 21, 2015 at 5:22 AM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > On Tue, Apr 21, 2015 at 05:05:31AM +0800, Frank.Li@xxxxxxxxxxxxx wrote: >> From: Frank Li <Frank.Li@xxxxxxxxxxxxx> >> >> Add i.MX7D clk tree support. >> >> + >> + clk_register_clkdev(clks[IMX7D_GPT1_ROOT_CLK], "ipg", "imx-gpt.0"); >> + clk_register_clkdev(clks[IMX7D_GPT_3M_CLK], "gpt_3m", "imx-gpt.0"); This patch just list all clock root in RM. all clock refine have to wait for Dong Aisheng's RFC clock framework change's patch. > > What are these good for? These shouldn't be here. > >> + >> + for (i = 0; i < IMX7D_END_CLK; i++) >> + clk_prepare_enable(clks[i]); > > Hey, no. You enable *all* clocks here which is certainly wrong. They > will never be turned off. Yes. This patches's purpose is bring up mx7. Because imx7 clock design change, Dong Aisheng send out RFC patch to change a little bit framework. After that, we can enable only necessary clock here. Otherwise system will halt and block the other part upstream. > >> @@ -309,12 +316,20 @@ struct clk *imx_clk_pllv3(enum imx_pllv3_type type, const char *name, >> case IMX_PLLV3_ENET: >> ops = &clk_pllv3_enet_ops; >> break; >> + case IMX_PLLV3_SYSV2: >> + ops = &clk_pllv3_ops; >> + break; >> default: >> ops = &clk_pllv3_ops; >> } >> pll->base = base; >> pll->div_mask = div_mask; >> >> + if (cpu_is_imx7d() && strcmp(name, "pll_enet_main") == 0) >> + pll->powerdown = ENET_PLL_POWER; >> + else >> + pll->powerdown = BM_PLL_POWER; > > You should probably add a new PLL type, like IMX_PLLV3_ENET_IMX7 or such > instead of using cpu_is_ and strcmp. Okay I will update it. > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
