Hi Magnus (2015/04/17 21:14), Magnus Damm wrote: > Hi Kobayashi-san, > > On Thu, Apr 16, 2015 at 7:35 PM, Keita Kobayashi > <keita.kobayashi.ym@xxxxxxxxxxx> wrote: >> Define ARM_RCAR_CPUIDLE config item to enable cpuidle >> support for Renesas R-Car Gen2 SoCs. >> >> Signed-off-by: Keita Kobayashi <keita.kobayashi.ym@xxxxxxxxxxx> >> --- >> drivers/cpuidle/Kconfig.arm | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm >> index 21340e0..1bff62e 100644 >> --- a/drivers/cpuidle/Kconfig.arm >> +++ b/drivers/cpuidle/Kconfig.arm >> @@ -74,3 +74,11 @@ config ARM_MVEBU_V7_CPUIDLE >> depends on ARCH_MVEBU && !ARM64 >> help >> Select this to enable cpuidle on Armada 370, 38x and XP processors. >> + >> +config ARM_RCAR_CPUIDLE >> + bool "CPU Idle Driver for the R-Car SoCs" >> + depends on ARCH_RCAR_GEN2 >> + depends on ARM_CPUIDLE >> + select ARM_CPU_SUSPEND >> + help >> + Select this to enable cpuidle for R-Car SoCs > > Thanks for your efforts. May I ask why we need a separate Kconfig > entry for this portion? It looks a bit overkill to me. > > I have not tried this myself, but it seems to me that you could simply > modify arch/arm/mach-shmobile/Kconfig something like this: > > config ARCH_RCAR_GEN2 > bool > select PM_RCAR if PM || SMP > + select ARM_CPU_SUSPEND if ARM_CPUIDLE > select RENESAS_IRQC > > and then in patch 2/5 use ARM_CPUIDLE for the #ifdefs instead of > ARM_RCAR_CPUIDLE. > > I think that would simplify things if possible. Thank you for your proposal. I will try it. > > Thanks, > > / magnus Regards. Keita Kobayashi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
