On Tue, Dec 31, 2024 at 8:42 PM Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote: [...] > +static const struct meson_sar_adc_param meson_sar_adc_gxlx_param = { > + .has_bl30_integration = true, > + .clock_rate = 1200000, > + .regmap_config = &meson_sar_adc_regmap_config_gxbb, > + .resolution = 12, > + .disable_ring_counter = 1, > + .vref_voltage = VREF_VOLTAGE_1V8, I just noticed that I did not properly rebase this locally. VREF_VOLTAGE_1V8 only exists in a local patch of mine (to be sent later, I assume Christian also has it in his tree which is why it wasn't noticed). Before this can be applied I need to change it to 1. I'll do this once the discussion is over and then send a v2. In other words: Jonathan, please don't merge v1.