On Mon, Jan 6, 2025 at 11:28 PM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote: > > > On Mon, 06 Jan 2025 01:07:16 +0400, Alexey Charkov wrote: > > H96 Max V58 is a compact TV box based on Rockchip RK3588 SoC [1] > > that ships with Android by default. Add support for it. > > > > Note that there is no publicly available hardware documentation, > > nor vendor sources to be used as a reference, so this implementation > > is best effort based on poking around my board and staring at the > > decompiled stock DTB. It works for me, but improvement suggestions > > are very much welcome. > > > > HDMI output is not tested, but expected to work. > > > > SPDIF output is not enabled (base RK3588 .dtsi needs amendment) > > > > Auxiliary LED display is not enabled (no mainline driver available). > > The controller used is FD6551 connected to GPIO3 RK_PC7 (clk) and > > GPIO3 RK_PD0 (data), which happen to be the right pins for > > i2c5m0_xfer pinctrl config, and thus might potentially be used with > > the hardware I2C5 controller (to be verified). Out of tree userspace > > driver is available at [2]. > > > > [1] https://www.h96tvbox.com/product/h96max-v58/ > > [2] https://github.com/arthur-liberman/linux_openvfd/blob/master/driver/controllers/fd650.c > > > > Signed-off-by: Alexey Charkov <alchark@xxxxxxxxx> > > --- > > Alexey Charkov (2): > > dt-bindings: arm: rockchip: Add H96 Max V58 TV box > > arm64: dts: rockchip: Add H96 Max V58 TV Box based on RK3588 SoC > > > > .../devicetree/bindings/arm/rockchip.yaml | 5 + > > arch/arm64/boot/dts/rockchip/Makefile | 1 + > > .../arm64/boot/dts/rockchip/rk3588-h96-max-v58.dts | 785 +++++++++++++++++++++ > > 3 files changed, 791 insertions(+) > > --- > > base-commit: af349ca4d3f8659d84abc667125c826fda155109 > > change-id: 20240618-rk3588-h96-max-v58-c2c1bf8e6996 > > > > Best regards, > > -- > > Alexey Charkov <alchark@xxxxxxxxx> > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y rockchip/rk3588-h96-max-v58.dtb' for 20250106-rk3588-h96-max-v58-v1-0-d25255f851fc@xxxxxxxxx: > > arch/arm64/boot/dts/rockchip/rk3588-h96-max-v58.dtb: syscon@fd5d0000: usb2phy@0:otg-port: 'vbus-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/soc/rockchip/grf.yaml# > arch/arm64/boot/dts/rockchip/rk3588-h96-max-v58.dtb: usb2phy@0: otg-port: 'vbus-supply' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/phy/rockchip,inno-usb2phy.yaml# > arch/arm64/boot/dts/rockchip/rk3588-h96-max-v58.dtb: regulator-3v3-pcie: gpios: [[267, 1, 0], [187, 20, 0]] is too long > from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml# > arch/arm64/boot/dts/rockchip/rk3588-h96-max-v58.dtb: regulator-3v3-pcie: Unevaluated properties are not allowed ('gpios' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml# Indeed. Will fix it in v2, sorry for the noise. Best, Alexey
