Hi, On 24-12-27 14:34, Vasily Khoruzhick wrote: > On Sat, Dec 7, 2024 at 9:45 AM Chris Morgan <macroalpha82@xxxxxxxxx> wrote: > > > Using git bisect, I found that this patch breaks the CONFIG_AXP20X_ADC > > option which is used by some of the battery and charger drivers for the > > axp20x PMIC series. My current assumption is that the > > devm_iio_channel_get() call made by these drivers worked correctly > > previously when the PLATFORM_DEVID_NONE, but now it's not working > > anymore. I'm still testing possible solutions for that problem. > > I confirm that this patch breaks the battery driver on Pinebook (and > likely Pinephone). Reverting it fixes the issue for me. > git bisect pointed me to this commit, when I've investigated why battery power supply stopped working on PinePhone. The problem is that devm_iio_channel_get() can't get channel by name, since consumer's name has changed (from "axp20x-battery-power-supply" to "axp20x-battery-power-supply.4.auto") and axp20x_adc has hardcoded consumer dev names [1]. For other readers of this thread there is related discussion here. [2] Chris, do you work on another solution of this problem? 1. https://elixir.bootlin.com/linux/v6.12.4/source/drivers/iio/adc/axp20x_adc.c#L176 2. https://lore.kernel.org/all/20241210224859.58917-1-macroalpha82@xxxxxxxxx/#t -- Best regards, Andrey Skvortsov
