Am Montag, 6. Januar 2025, 09:35:26 CET schrieb Andy Yan:
>
> Hi Heiko,
>
> At 2025-01-02 19:51:58, "Heiko Stübner" <heiko@xxxxxxxxx> wrote:
> >Hi Andy,
> >
> >Am Mittwoch, 25. Dezember 2024, 11:37:29 CET schrieb Andy Yan:
> >> From: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
> >>
> >> There are some control bits for IO and interrupts status scattered
> >> across different GRF on differt SOC.
> >> Add platform callback for this IO setting and interrupts status
> >> handling.
> >>
> >> Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
> >>
> >> ---
> >>
> >> .../gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 81 ++++++++++++-------
> >> 1 file changed, 54 insertions(+), 27 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
> >> index c36fc130b734..b21e868e7c16 100644
> >> --- a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
> >> +++ b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
> >> @@ -62,6 +62,12 @@ struct rockchip_hdmi_qp {
> >> int port_id;
> >> };
> >>
> >> +struct rockchip_hdmi_qp_ctrl_ops {
> >> + void (*io_init)(struct rockchip_hdmi_qp *hdmi);
> >> + irqreturn_t (*irq_callback)(int irq, void *dev_id);
> >> + irqreturn_t (*hardirq_callback)(int irq, void *dev_id);
> >> +};
> >> +
> >> static struct rockchip_hdmi_qp *to_rockchip_hdmi_qp(struct drm_encoder *encoder)
> >> {
> >> struct rockchip_encoder *rkencoder = to_rockchip_encoder(encoder);
> >> @@ -226,9 +232,47 @@ static irqreturn_t dw_hdmi_qp_rk3588_irq(int irq, void *dev_id)
> >> return IRQ_HANDLED;
> >> }
> >>
> >> +static void dw_hdmi_qp_rk3588_io_init(struct rockchip_hdmi_qp *hdmi)
> >> +{
> >> + u32 val;
> >> +
> >> + val = HIWORD_UPDATE(RK3588_SCLIN_MASK, RK3588_SCLIN_MASK) |
> >> + HIWORD_UPDATE(RK3588_SDAIN_MASK, RK3588_SDAIN_MASK) |
> >> + HIWORD_UPDATE(RK3588_MODE_MASK, RK3588_MODE_MASK) |
> >> + HIWORD_UPDATE(RK3588_I2S_SEL_MASK, RK3588_I2S_SEL_MASK);
> >> +
> >
> >nit: below val = ... and regmap_write don't have a blank line between them
> >which makes sense to show that they belong together. So the blank above
> >can probably also go away.
>
> Okay, it will be removed in V2.
just realized that I commented on the "wrong" version :-)
https://lore.kernel.org/r/20241231094425.253398-1-andyshrk@xxxxxxx
seems to be the most recent one.
Heiko
