Am Mittwoch, 25. Dezember 2024, 11:37:31 CET schrieb Andy Yan:
> From: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
>
> The HDMI on RK3576 shares the same IP block (PHY and Controller)
> with rk3588.
> However, there are some control bits scattered in different GRF.
>
> Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
> Signed-off-by: Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx>
> Tested-by: Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx>
The attribution is strange. Where does the Signed-off from Detlev come
from?
At that position it would mean that he's the sender, but that's obviously
not the case.
I guess it's either just the Tested-by ... or you need an additional
Co-Developed-by if Detlev contributed to this patch.
> ---
>
> .../gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 143 +++++++++++++++++-
> 1 file changed, 141 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
> index b21e868e7c16..bd9216e45e74 100644
> --- a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
[...]
> @@ -287,8 +422,12 @@ static const struct rockchip_hdmi_qp_cfg rk3588_hdmi_cfg = {
> };
>
> static const struct of_device_id dw_hdmi_qp_rockchip_dt_ids[] = {
> - { .compatible = "rockchip,rk3588-dw-hdmi-qp",
> - .data = &rk3588_hdmi_cfg },
> + { .compatible = "rockchip,rk3576-dw-hdmi-qp",
> + .data = &rk3576_hdmi_cfg
> + }, {
> + .compatible = "rockchip,rk3588-dw-hdmi-qp",
> + .data = &rk3588_hdmi_cfg
> + },
nit: please keep consistent styling between the listentries. Right now the
rk3576 and changed rk3588 entries use different styles.
Heiko
