Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Radxa E52C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

Am Freitag, 3. Januar 2025, 07:45:58 CET schrieb FUKAUMI Naoki:
> Hi Kever,
> 
> What do you think about the introduction of the "rockchip,rk3582" 
> compatibility string?

I'm not Kever, but I do like the way you did this :-) .

I.e. the rk3582 _is_ a rk3588 with those cores disabled.

So going the way you did allows us to not introduce too much
overhead while still already having the rk3582 naming in there
if it becomes necessary later on.


Heiko


> --
> FUKAUMI Naoki
> Radxa Computer (Shenzhen) Co., Ltd.
> 
> On 12/26/24 11:46, FUKAUMI Naoki wrote:
> > Add devicetree binding for the Radxa E52C.
> > 
> > Radxa E52C is a compact network computer based on the Rockchip RK3582
> > SoC.
> > 
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Signed-off-by: FUKAUMI Naoki <naoki@xxxxxxxxx>
> > ---
> > Changes in v3:
> > - Collect A-b tag
> > Changes in v2:
> > - Add "rockchip,rk3588s"
> > ---
> >   Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
> >   1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > index 753199a12923..2152d170524a 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -812,6 +812,12 @@ properties:
> >             - const: radxa,e20c
> >             - const: rockchip,rk3528
> >   
> > +      - description: Radxa E52C
> > +        items:
> > +          - const: radxa,e52c
> > +          - const: rockchip,rk3582
> > +          - const: rockchip,rk3588s
> > +
> >         - description: Radxa Rock
> >           items:
> >             - const: radxa,rock
> 
> 








[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux