On 04/01/2025 10:23, Xukai Wang wrote:
>
> Here's the update version:
>
> reg:
> description: |
> The `reg` property specifies the base address and size of the
> device's registers.
> - The first address corresponds to the base address of the PLL
> control registers.
> - The second address corresponds to the base address of the sysclk
> control registers.
No, drop all these. You duplicate schema.
> minItems: 1
Why?
> items:
> - description: Base address and size of the PLL control registers.
> - description: Base address and size of the sysclk control registers.
Drop redundant "Base address and size of the". This cannot be anything
else in this context.
>
> Does this content look appropriate?
>
>>> +
>>> + '#clock-cells':
>>> + const: 1
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - clocks
>>> + - '#clock-cells'
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + clock-controller@91102000 {
>>> + compatible = "canaan,k230-clk";
>>> + reg = <0x91102000 0x1000>, <0x91100000 0x1000>;
>>> + #clock-cells = <1>;
>>> + clocks = <&osc24m>;
>>> + };
>>> diff --git a/include/dt-bindings/clock/k230-clk.h b/include/dt-bindings/clock/k230-clk.h
I missed one thing - filename is supposed to be the same as binding
filename.
Best regards,
Krzysztof
