On Fri, Jan 03, 2025 at 08:45:17PM +0000, Lukas Schmid wrote: > Signed-off-by: Lukas Schmid <lukas.schmid@xxxxxxxxxx> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Signed-off-by: Lukas Schmid <lukas.schmid@xxxxxxxxxx> Repeating again one of my comments: Please run scripts/checkpatch.pl and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Please implement all comments. Best regards, Krzysztof
