On Sat, Apr 18, 2015 at 11:45:13AM +0200, Paul Kocialkowski wrote:
> Le samedi 18 avril 2015 à 10:13 +0100, Russell King - ARM Linux a
> écrit :
> > Hi,
> >
> > On Fri, Apr 17, 2015 at 08:43:55PM +0200, Paul Kocialkowski wrote:
> > > static int __init init_machine_late(void)
> > > {
> > > +#ifdef CONFIG_OF
> > > + unsigned long dt_root;
> > > + int size;
> > > +
> > > + dt_root = of_get_flat_dt_root();
> > > +
> > > + /* Scan for serial number */
> > > + system_serial = of_get_flat_dt_prop(dt_root, "serial-number", &size);
> >
> > I was really hoping for:
> >
> > if (of_property_read_string(of_root, "serial-number", &system_serial))
> > system_serial = NULL;
> >
> > here. I can't see a reason to use the flattened DT at this point as
> > we've already parsed it.
>
> Good point -- I'm not very used to using device-tree so I didn't think
> of it, thanks for mentioning it.
>
> At this point, I guess I can also add your Signed-Off-By to the patch.
No - Signed-off-by is to indicate the path by which it was committed
into the git tree, not for review, etc.
I'm assuming you'll be submitting this to my patch system eventually,
which means when I apply the patch, it'll have my S-o-b automatically
added.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
