Le samedi 18 avril 2015 à 10:13 +0100, Russell King - ARM Linux a
écrit :
> Hi,
>
> On Fri, Apr 17, 2015 at 08:43:55PM +0200, Paul Kocialkowski wrote:
> > static int __init init_machine_late(void)
> > {
> > +#ifdef CONFIG_OF
> > + unsigned long dt_root;
> > + int size;
> > +
> > + dt_root = of_get_flat_dt_root();
> > +
> > + /* Scan for serial number */
> > + system_serial = of_get_flat_dt_prop(dt_root, "serial-number", &size);
>
> I was really hoping for:
>
> if (of_property_read_string(of_root, "serial-number", &system_serial))
> system_serial = NULL;
>
> here. I can't see a reason to use the flattened DT at this point as
> we've already parsed it.
Good point -- I'm not very used to using device-tree so I didn't think
of it, thanks for mentioning it.
At this point, I guess I can also add your Signed-Off-By to the patch.
> I'd also put this after the call to machine_desc->init_late().
Will do.
Attachment:
signature.asc
Description: This is a digitally signed message part
