On Mon, Dec 30, 2024 at 11:43:35AM +0800, Karl.Li wrote: > From: Karl Li <karl.li@xxxxxxxxxxxx> > > Add devicetree binding for apu-mailbox. A nit, subject: drop second/last, redundant "dt-bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 I already asked for this. > > MediaTek APU (AI Processing Unit) is a microcontroller unit > designed for AI acceleration tasks. The MediaTek APU-Mailbox > facilitates communication with the APU microcontroller. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: Karl Li <karl.li@xxxxxxxxxxxx> > --- > .../mailbox/mediatek,apu-mailbox.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml > > diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml > new file mode 100644 > index 000000000000..fdb0dec5fb78 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/mediatek,apu-mailbox.yaml Use compatible as filename. Best regards, Krzysztof
