On Wed, Dec 25, 2024 at 04:26:19PM -0300, Val Packett wrote: > Add compatibles for SoCs using this device (mt8183, mt8365, mt8516). This we see from the diff. Say what is less visible, e.g. are they fully compatible with other variants? Partially? Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> --- <form letter> This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 </form letter> Best regards, Krzysztof