On Tue, Dec 24, 2024 at 05:23:08PM +0800, Kever Yang wrote: > Document the device tree bindings of the rockchip rk3562 SoC > clock and reset unit. > > Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx> > --- A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 s/rk3562/Rocchip RK3562/ or whatever your proper name is (and use proper capitalized parts of products) > +properties: > + compatible: > + const: rockchip,rk3562-cru > + > + reg: > + maxItems: 1 > + > + "#clock-cells": > + const: 1 > + > + "#reset-cells": > + const: 1 > + > + clocks: > + maxItems: 2 Why clocks are not required? > + > + clock-names: > + items: > + - const: xin24m > + - const: xin32k > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + - "#reset-cells" > + > +additionalProperties: false > + > +examples: > + - | > + clock-controller@ff100000 { > + compatible = "rockchip,rk3562-cru"; > + reg = <0xff100000 0x40000>; > + #clock-cells = <1>; > + #reset-cells = <1>; Why clocks are not here? Best regards, Krzysztof
