Re: [PATCH 3/3] arm64: dts: qcom: qcs615-ride: Enable RX programmable swap on qcs615-ride

Yijie Yang <quic_yijiyang@xxxxxxxxxxx> · Thu, 26 Dec 2024 09:23:55 +0800

On 2024-12-26 01:38, Andrew Lunn wrote:
On Wed, Dec 25, 2024 at 06:04:47PM +0800, Yijie Yang wrote:
The timing of sampling at the RX side for qcs615-ride needs adjustment.
It varies from board to board.

Signed-off-by: Yijie Yang <quic_yijiyang@xxxxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/qcs615-ride.dts | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
index bfb5de4a0d440efece993dbf7a0001e001d5469b..f22a4a0b247a09bd1057b66203a34b666cd119a8 100644
--- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
@@ -206,6 +206,7 @@ &ethernet {
  	phy-handle = <&rgmii_phy>;
  	phy-mode = "rgmii";
  	max-speed = <1000>;
+	qcom,rx-prog-swap;

I notice this board still has messed up rgmii delays, using phy-mode =
"rgmii", not "rgmii-id". How does com,rx-prog-swap interact with rgmii
delays? Is the sample point logic before or after the rgmii delay
logic in the MAC clock pipeline?

This patch set relies on an earlier version that has RGMII issues. The 
latter is still undergoing coding and verification. I will update this 
patch set once the RGMII issues are resolved and uploaded.


I think i also questioned max-speed = <1000>. Has this
arch/arm64/boot/dts/qcom/qcs615-ride.dts been merged?

This will also be updated in the next version.


	Andrew

--
Best Regards,
Yijie








