On 2024-12-26 00:17, Andrew Lunn wrote:
On Wed, Dec 25, 2024 at 04:58:20PM +0800, Yijie Yang wrote:
On 2024-12-24 17:02, Krzysztof Kozlowski wrote:
On 24/12/2024 04:07, Yijie Yang wrote:
The core version of EMAC on qcs615 has minor differences compared to that
on sm8150. During the bring-up routine, the loopback bit needs to be set,
and the Power-On Reset (POR) status of the registers isn't entirely
consistent with sm8150 either.
Therefore, it should be treated as a separate entity rather than a
fallback option.
... and explanation of ABI impact? You were asked about this last time,
so this is supposed to end up here.
I actually replied to this query last time, but maybe it wasn't clear.
Firstly, no one is using Ethernet on this platform yet. Secondly, the
previous fallback to sm8150 is incorrect and causes packet loss. Instead, it
should fall back to qcs404.
One of the purposes of the commit message is to answer questions
reviews might have. You were even asked this question, so that should
of been a clue to include the answer in the commit message.
I will include it in the commit message in the next version.
Andrew
--
Best Regards,
Yijie
