> > On Tue, Dec 17, 2024 at 02:51:43PM +0800, Sandor Yu wrote: > > Cadence MHDP IP includes a firmware. Driver and firmware communicate > > through a mailbox. The basic mailbox access functions in this patch > > are derived from the DRM bridge MHDP8546 driver. > > New mailbox access functions have been created based on different > > mailbox return values and security types, making them reusable across > > different MHDP driver versions and SOCs. > > > > These helper fucntions will be reused in both the DRM bridge driver > > MDHP8501 and the i.MX8MQ HDPTX PHY driver. > > > > Six mailbox access helper functions are introduced. > > Three for non-secure mailbox access: > > - cdns_mhdp_mailbox_send() > > - cdns_mhdp_mailbox_send_recv() > > - cdns_mhdp_mailbox_send_recv_multi() > > The other three for secure mailbox access: > > - cdns_mhdp_secure_mailbox_send() > > - cdns_mhdp_secure_mailbox_send_recv() > > - cdns_mhdp_secure_mailbox_send_recv_multi() > > > > All MHDP commands that need to be passed through the mailbox should be > > rewritten using these new helper functions. > > > > The register read/write and DP DPCD read/write command functions are > > also included in this new helper driver. > > > > Signed-off-by: Sandor Yu <Sandor.yu@xxxxxxx> > > --- > > v19->v20: > > - new patch in v20. > > The patch split from Patch #1 in v19 and move to a new folder > > drivers/soc/cadence > > It makes it harder to review, but granted that we have already past that, I > think it's fine. > > > > > diff --git a/drivers/soc/cadence/Kconfig b/drivers/soc/cadence/Kconfig > > new file mode 100644 index 0000000000000..b668790660fa5 > > --- /dev/null > > +++ b/drivers/soc/cadence/Kconfig > > @@ -0,0 +1,9 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +config CDNS_MHDP_HELPER > > + tristate "Cadence MHDP Helper driver" > > This symbol isn't supposed to be selected by the user. Please leave just > tristate without the menu entry text (the help text is fine, please keep it). > > LGTM otherwise. OK, thanks, I will remove the menu entry text. B.R Sandor > > > + help > > + Enable Cadence MHDP helpers for mailbox, HDMI and DP. > > + This driver provides a foundational layer of mailbox > communication for > > + various Cadence MHDP IP implementations, such as HDMI and > DisplayPort. > > + > > -- > With best wishes > Dmitry
