On Tue, Dec 24, 2024 at 7:49 AM Leyfoon Tan
<leyfoon.tan@xxxxxxxxxxxxxxxx> wrote:
>
>
>
> > -----Original Message-----
> > From: Anup Patel <apatel@xxxxxxxxxxxxxxxx>
> > Sent: Monday, December 16, 2024 4:48 PM
> > To: Michael Turquette <mturquette@xxxxxxxxxxxx>; Stephen Boyd
> > <sboyd@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> > <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Jassi Brar
> > <jassisinghbrar@xxxxxxxxx>
> > Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>; Paul Walmsley
> > <paul.walmsley@xxxxxxxxxx>; Sunil V L <sunilvl@xxxxxxxxxxxxxxxx>; Rahul
> > Pathak <rpathak@xxxxxxxxxxxxxxxx>; Leyfoon Tan
> > <leyfoon.tan@xxxxxxxxxxxxxxxx>; Atish Patra <atishp@xxxxxxxxxxxxxx>;
> > Andrew Jones <ajones@xxxxxxxxxxxxxxxx>; Anup Patel
> > <anup@xxxxxxxxxxxxxx>; linux-clk@xxxxxxxxxxxxxxx;
> > devicetree@xxxxxxxxxxxxxxx; linux-riscv@xxxxxxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; Anup Patel <apatel@xxxxxxxxxxxxxxxx>
> > Subject: [RFC PATCH 2/8] dt-bindings: mailbox: Add bindings for RPMI shared
> > memory transport
> >
> [...]
>
> > +
> > +examples:
> > + - |
> > + // Example 1 (RPMI shared memory with only 2 queues):
> > + mailbox@10080000 {
> > + compatible = "riscv,rpmi-shmem-mbox";
> > + reg = <0x00 0x10080000 0x00 0x10000>,
> > + <0x00 0x10090000 0x00 0x10000>,
> > + <0x00 0x100a0000 0x00 0x4>;
> > + reg-names = "a2p-req", "p2a-ack", "db-reg";
> > + msi-parent = <&imsic_mlevel>;
> > + riscv,slot-size = <64>;
> > + #mbox-cells = <1>;
> > + };
> > + - |
> > + // Example 2 (RPMI shared memory with only 4 queues):
> > + mailbox@10001000 {
> > + compatible = "riscv,rpmi-shmem-mbox";
> > + reg = <0x00 0x10001000 0x00 0x800>,
> > + <0x00 0x10001800 0x00 0x800>,
> > + <0x00 0x10002000 0x00 0x800>,
> > + <0x00 0x10002800 0x00 0x800>,
> > + <0x00 0x10003000 0x00 0x4>;
> > + reg-names = "a2p-req", "p2a-ack", "db-reg";
>
> reg has 5 entries, missing 2 reg-names?
copy-paste error, thanks for catching.
Regards,
Anup
>
> > + msi-parent = <&imsic_mlevel>;
> > + riscv,slot-size = <64>;
> > + riscv,db-mask = <0x00008000>;
> > + riscv,db-value = <0x00008000>;
> > + #mbox-cells = <1>;
> > + };
> > --
> > 2.43.0
>
> Regards
> Ley Foon
