On 22/12/2024 16:07, Maya Matuszczyk wrote: > > With similar ones at the end: > Devkit: > EC VER:00.29.00$ > LsFv:00.29.00$ > Qualcomm$ > WoS 8c GenX$ > ODM$ > MB:A0$ > BUILD DATE: > 02/0//2/24$ > TIME: > 14:33:35$ > > Slim7x: > EC VER:00.60.00$ > LsFv:00.20.00$ > Qualcomm$ > WoS 8c GenX$ > ODM$ > MB:A0$ > BUILD DATE: > 2024/07/25$ > TIME: > 09:58:00$ > > > >> >> If the FW across devices is the same, then fallbacks for these are fine >> with me. > > As the devkit has EC firmware that is handled the same way in DSDT > tables of most of other x1e laptops with the same EC, and is a subset > of what's done on Lenovo Yoga Slim 7x and Honor Magicbook Art 14 I > think the devkit's compatible + -ec would be a good pick. > > This conversation is getting long and I feel like I've said everything > I wanted to say, I'll just do what you tell me to do about the > fallback and binding filename. Go with a device specific compatible (I think I proposed in other email). It is up to you if you want to add fallbacks. If you add fallbacks, then please include some summary of above in commit msg or binding description, so there will be a trace of that explanation/reason for fallbacks. Best regards, Krzysztof
