Hi Krzysztof,
On Sat, Nov 23, 2024 at 10:14 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Fri, Nov 22, 2024 at 03:36:23PM +0530, Shubhrajyoti Datta wrote:
> > Add device tree bindings for AMD Versal NET EDAC for DDR controller.
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxx>
> > ---
> >
>
..
> > +
> > + amd,dwidth:
> > + description:
> > + DDR memory controller device width.
>
> Use existing properties.
I am not finding any existing properties could you help me with some pointers.
>
>
> > + enum: [16, 32]
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + amd,num-chans:
> > + description:
> > + Number of channels.
>
> Use existing properties, e.g. some of the DDR schemas describing memory.
> Look how other bindings describe actual chips.
could you share any example. My search didnt return anything
>
> > + enum: [1, 2]
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + amd,num-rank:
> > + description:
> > + Number of rank.
> > + enum: [1, 2, 4]
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +required:
> > + - compatible
>
> Eh, no resources? How do you talk with the hardware? This looks way too
> Linuxy...
will add a remote proc property
amd,rproc:
$ref: /schemas/types.yaml#/definitions/phandle
description:
phandle to the remoteproc_r5 rproc node using which APU interacts
with remote processor.
memory-controller {
...
amd,rproc = <&remoteproc_r5>;
};
>
> Best regards,
> Krzysztof
>
>
