On 14/12/2024 10:10, Krzysztof Kozlowski wrote: > On 13/12/2024 17:32, Vincenzo Frascino wrote: >> Add support for "interrupt-names" and "mbox-name" optional properties. > > Why? > > > I wonder why you are not cc-ing other maintainers, like only Rob is > acceptable by you? > No it is not. And this is why it is not a good idea to post patches on Friday night. My intention was to copy linux-arm-kernel but I copied mistakenly linux-kernel instead. I do apologize. I will fix this in the next iteration. > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC (and consider --no-git-fallback argument, so you will > not CC people just because they made one commit years ago). It might > happen, that command when run on an older kernel, gives you outdated > entries. Therefore please be sure you base your patches on recent Linux > kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). Just use b4 and everything should be > fine, although remember about `b4 prep --auto-to-cc` if you added new > patches to the patchset. > </form letter> > >> >> Cc: Sudeep Holla <sudeep.holla@xxxxxxx> >> Cc: Rob Herring <robh@xxxxxxxxxx> >> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx> >> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx> >> --- >> Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml >> index d9a4f4a02d7c..65a4f66a7273 100644 >> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml >> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml >> @@ -63,6 +63,16 @@ properties: >> - description: high-priority non-secure >> - description: Secure >> >> + interrupt-names: >> + minItems: 2 >> + items: >> + - const: mhu-lpri-rx >> + - const: mhu-hpri-rx >> + - const: mhu-si-rx > > No, drop. > >> + >> + mbox-name: >> + maxItems: 1 > > No clue what's this, for sure there is no such property at all and > commit msg does not explain it. > > > Drop entire patch. > Fine. > Best regards, > Krzysztof -- Regards, Vincenzo
