On Thu, Dec 19, 2024 at 12:40:30PM +0100, Krzysztof Kozlowski wrote: > On 19/12/2024 11:51, Charles Keepax wrote: > > On Thu, Dec 19, 2024 at 09:48:05AM +0100, Krzysztof Kozlowski wrote: > >> On Wed, Dec 18, 2024 at 08:46:31PM -0600, Paul Handrigan wrote: > >>> +#define CS2600_PLL_OUT 0 > >>> +#define CS2600_CLK_OUT 1 > >>> +#define CS2600_BCLK_OUT 2 > >>> +#define CS2600_FSYNC_OUT 3 > >> > >> No, the entire point of the binding header is to bind. Drop all four > >> above and use properly your header. > >> > >> Otherwise I claim your binding header is not used or not really a > >> binding. > > > > This excert is from the drivers internal header not the binding > > header? > I replied in patch two, stripping unnecessary context. There is no > binding header here, so I do not understand your comment. Ah sorry yes my bad, you mean drop these defines and use the ones from the binding header instead. Thanks, Charles
