On 12/13/24 20:55, Xu Yang wrote:
On Fri, Dec 13, 2024 at 07:25:32PM +0800, Hui Wang wrote:
On 12/13/24 16:17, Xu Yang wrote:
Hi,
On Thu, Dec 12, 2024 at 12:31:26PM +0800, Hui Wang wrote:
For the chipidea usb driver, if the dr_mode is not set, it will set
the device to otg mode by default, so here the dr_mode has not been
set for a long time. But some testcases need to parse the dr_mode from
DT and decide the follow-up test strategy, here set the dr_mode to otg
explicitly for QA's testcases.
The dr_mode is board specific property, so we normally don't put it in
dtsi file. Also, imx6qdl.dtsi is a common dtsi, therefore it's not a
correct place. I wonder you don't set dr_mode in other dts file which
include will imx6qdl.dtsi?
Yes, our QA reported this issue against the imx6q-sabresd board, I thought
dr_mode could be overwritten if board dts set the dr_mode, so this change
will not impact existing boards. But as you said "we normally don't put it
in dtsi file", I will move it to imx6q-sabresd.dts.
Okay. You can move it to imx6qdl-sabresd.dtsi too. Then you can reuse
&usbotg {}.
Yes, for sure.
Thanks,
Hui.
Thanks,
Xu Yang
Thanks,
Hui.
Thanks,
Xu Yang
Signed-off-by: Hui Wang <hui.wang@xxxxxxxxxxxxx>
---
arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
index d2200c9db25a..285fb7314a88 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
@@ -982,6 +982,7 @@ usbotg: usb@2184000 {
clocks = <&clks IMX6QDL_CLK_USBOH3>;
fsl,usbphy = <&usbphy1>;
fsl,usbmisc = <&usbmisc 0>;
+ dr_mode = "otg";
ahb-burst-config = <0x0>;
tx-burst-size-dword = <0x10>;
rx-burst-size-dword = <0x10>;
--
2.34.1
